dsmiley commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1623133317
##########
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##########
@@ -391,6 +402,21 @@ protected NamedList<Object>
loadConfigSetFlags(SolrResourceLoader loader) throws
*/
protected abstract SolrResourceLoader
createCoreResourceLoader(CoreDescriptor cd);
+ /**
+ * Create a SolrResourceLoader for a core with the provided configSetName.
+ *
+ * <p>By default, this will just call {@link
+ * ConfigSetService#createConfigSetService(CoreContainer)}. Child
implementation might override
+ * this to make use of the configSetName directly
+ *
+ * @param cd the core's CoreDescriptor
+ * @param configSetName an optional config set name
+ * @return a SolrResourceLoader
+ */
+ protected SolrResourceLoader createCoreResourceLoader(CoreDescriptor cd,
String configSetName) {
Review Comment:
Since the configSetName is also on the CoreDescriptor, isn't this API
needless? Same elsewhere (loadConfigSet)
##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -314,6 +182,19 @@ public CloudDescriptor getCloudDescriptor() {
};
}
+ /**
+ * Overrides the MDC context as the core set was synthetic core, which does
not reflect the
+ * collection being operated on
+ */
+ private static void setMDCLoggingContext(String collectionName) {
Review Comment:
We use Google Java code standards, thus use "Mdc" capitalization. Plenty of
old code did a mis-mash of things, MDCLoggingContext being one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
