dsmiley commented on PR #2497: URL: https://github.com/apache/solr/pull/2497#issuecomment-2149871311
I suggest flipping the order. Prep the code for Java 21 compatibility first so that we don't go adding SupressForbidden to many classes to only then fix the issue later. i.e. visit these classes once not twice. You know exactly how to fix it and have even starting doing so; it's not a tricky matter. Again, IntelliJ will do much of the work. On Wed, Jun 5, 2024 at 8:55 AM Sanjay Dutt ***@***.***> wrote: > Would it be too much to ask to separate all this URL conversion stuff to a > separate PR, ultimately being its own commit focused on exactly that? > Needn't be another JIRA; needn't touch CHANGES.txt in that commit. If I had > to do this, I'd start with the trick of taking a GitHub PR URL and adding > the ".patch" (or maybe it's ".diff" for a different format) and then > copy-paste into IntellIJ "Apply patch from Clipboard" and selectively > exclude stuff unrelated at that point (or after). > > So SuppressForbidden is okay for now, and later on (Just after this one!) > deal with removing it in a different PR? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/solr/pull/2497#issuecomment-2149791390>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAC4DTZJTS2ICJN2TM6AJZLZF4C77AVCNFSM6AAAAABIY26TRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBZG44TCMZZGA> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
