cpoerschke commented on code in PR #2478:
URL: https://github.com/apache/solr/pull/2478#discussion_r1638122281
##########
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##########
@@ -151,8 +151,9 @@ public Codec getCodec() {
}
/**
- * This class exists because Lucene95HnswVectorsFormat's getMaxDimensions
method is final and we
- * need to workaround that constraint to allow more than the default number
of dimensions
+ * This class exists because {@link
Lucene99HnswVectorsFormat#getMaxDimensions(String)} method is
+ * final and we need to workaround that constraint to allow more than the
default number of
Review Comment:
Actually the method is not (no longer?) final:
https://github.com/apache/lucene/blob/releases/lucene/9.10.0/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java#L220
edit: never mind, the method is not final but the class is:
https://github.com/apache/lucene/blob/releases/lucene/9.10.0/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java#L86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
