stephen-woods commented on PR #2506:
URL: https://github.com/apache/solr/pull/2506#issuecomment-2174618911
Fair enough... I recognize that introducing a bounded wild card would
normally be a breaking change, but in this particular case, the boundary is
consistent with the one that `TopDocsCollector` already has in place (and has
had since the stone age). All `TopDocsCollectors` are upper bounded to
`ScoreDoc`.
```java
public abstract class TopDocsCollector<T extends ScoreDoc> implements
Collector {
```
Given that.... it really isn't a breaking change. All previously RankQuery
classes that worked in Solr 8.x work again after this PR change. It's actually
the same thing at runtime as what the previous raw type had (because of the
bounds in the `TopDocsCollector` class). Making it invariant was the change
that was breaking.
But yeah... take a look at the other commit I made that introduces the type
variable into `RankQuery` and see if that addresses your concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
