janhoy commented on code in PR #2540: URL: https://github.com/apache/solr/pull/2540#discussion_r1663325672
########## solr/bin/solr.cmd: ########## @@ -246,11 +246,12 @@ set FIRST_ARG=%1 IF [%1]==[] goto usage -IF "%1"=="-help" goto usage -IF "%1"=="-usage" goto usage -IF "%1"=="-h" goto usage -IF "%1"=="--help" goto usage -IF "%1"=="/?" goto usage +IF "%1"=="-help" goto run_solrcli +IF "%1"=="-usage" goto run_solrcli +IF "%1"=="-h" goto run_solrcli +IF "%1"=="--help" goto run_solrcli +IF "%1"=="-help" goto run_solrcli +IF "%1"=="/?" goto run_solrcli IF "%1"=="status" goto get_status IF "%1"=="version" goto run_solrcli IF "%1"=="-v" goto run_solrcli Review Comment: The other PR with better help formatting is an enabler.. Maybe add a handful new sub-tasks to your umbrella JIRA - not sure if one JIRA per area (migrate usage) or one JIRA per tool (healthcheck etc) makes the most sense. Maybe one per tool, and we do one PR as an example and invite dev-list to pick the others? Removing usesless ENV translation can have one JIRA and multiple PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
