cpoerschke commented on code in PR #2549:
URL: https://github.com/apache/solr/pull/2549#discussion_r1664063443
##########
.github/workflows/stale.yml:
##########
@@ -29,10 +29,9 @@ jobs:
stale-pr-label: "stale" # label to use when marking as stale
stale-pr-message: >
- This PR had no visible activity in the past 60 days, labeling it
as stale.
- Any new activity will remove the stale label. To attract more
reviewers, please tag
- someone or notify the [email protected] mailing list.
+ This PR has had no activity for 60 days and is now labeled as
stale.
+ Any new activity or setting it as a draft will remove the stale
label.
Review Comment:
I like the mention of 'draft' as a choice. How about rewording to make it
closer to the 'Convert to draft' UI element?
```suggestion
Any new activity or converting it to draft will remove the stale
label.
```
##########
.github/workflows/stale.yml:
##########
@@ -29,10 +29,9 @@ jobs:
stale-pr-label: "stale" # label to use when marking as stale
stale-pr-message: >
- This PR had no visible activity in the past 60 days, labeling it
as stale.
- Any new activity will remove the stale label. To attract more
reviewers, please tag
- someone or notify the [email protected] mailing list.
+ This PR has had no activity for 60 days and is now labeled as
stale.
+ Any new activity or setting it as a draft will remove the stale
label.
+ To attract more reviewers, tag someone or notify the
[email protected] mailing list.
Review Comment:
Maybe we could broaden from '(some)one' to 'several' (which might be less or
more daunting depending on point of view) and say a little more about how to
identify people to tag?
```suggestion
To attract more reviewers, tag people who might be familiar with
the code area and/or notify the [email protected] mailing list.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]