dsmiley commented on code in PR #2534:
URL: https://github.com/apache/solr/pull/2534#discussion_r1667072161
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -201,9 +201,10 @@ public static CommandLine parseCmdLine(String toolName,
String[] args, List<Opti
}
public static String getDefaultSolrUrl() {
- String scheme = EnvUtils.getEnv("SOLR_URL_SCHEME", "http");
- String host = EnvUtils.getEnv("SOLR_TOOL_HOST", "localhost");
- String port = EnvUtils.getEnv("SOLR_PORT", "8983");
+ // note that ENV_VAR syntax (and the env vars too) are mapped to env.var
sys props
+ String scheme = EnvUtils.getProperty("SOLR_URL_SCHEME", "http");
+ String host = EnvUtils.getProperty("SOLR_TOOL_HOST", "localhost");
+ String port = EnvUtils.getProperty("SOLR_PORT", "8983");
Review Comment:
I was mistaken; "camelCaseToDotSeparated" is not the same as "[screaming
snake case](https://www.theserverside.com/definition/Snake-case)". It could
have used a commented example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
