gerlowskija commented on code in PR #2499:
URL: https://github.com/apache/solr/pull/2499#discussion_r1668746772
##########
solr/core/src/java/org/apache/solr/schema/TextField.java:
##########
@@ -165,6 +167,20 @@ public Query getFieldTermQuery(QParser parser, SchemaField
field, String externa
return new TermQuery(new Term(field.getName(), br));
}
+ @Override
+ public Query getPrefixQuery(QParser parser, SchemaField sf, String termStr) {
+ final var query = super.getPrefixQuery(parser, sf, termStr);
Review Comment:
Well there is _some_ harm, albeit small. A prefix query on a "known safe"
field type like Enum might trigger the limit, and cause the "Admin
aggravation/annoyance" we've discussed and tried to minimize throughout this PR.
That'd require a user to submit a query like `my_enum_field:i*`, which is
presumably a pretty rare case. But you can imagine a user maybe doing that as
a shorthand way to get docs matching a few target enum values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
