malliaridis commented on code in PR #2550:
URL: https://github.com/apache/solr/pull/2550#discussion_r1676978086


##########
solr/solr-ref-guide/ui-src/css/tabs.css:
##########
@@ -0,0 +1,103 @@
+.tabs {

Review Comment:
   I would resolve this for now without adding to the file a license header 
yet, as your point @gerlowskija about size/network-transfer might be 
significant.
   
   We may consider a minified license header for these files or configure Gulp 
to strip headers and add a license header to the minified files at build time, 
so that there are no multiple license headers in the files of the bundle. I am 
also not sure if the current gulp configuration does any cleanup or 
minification before bundling that may remove existing headers / comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to