bogdanstoik commented on PR #2557: URL: https://github.com/apache/solr/pull/2557#issuecomment-2231681249
> > thanks for the addition of the tests.. I will inline some comments.... one thing, did you run `gradlew tidy`? that does some code formatting. > > I did not 🤦♂️. I had a blast writing java for the first time in 10 years. I promise I'll try to contribute more to the project, as it's a key part in my job. The only thing i'm not sure about is passing the params to the /extract component of the webMode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
