[
https://issues.apache.org/jira/browse/SOLR-15689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-15689:
---------------------------------------
Description:
Noticed whilst code reading that the
{code}
...
if (ourLowThreshold > otherHigh && ourHighest >= otherHighest) {
...
{code}
comparison e.g.
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.10.0/solr/core/src/java/org/apache/solr/update/PeerSync.java#L792
presumes that the {{Highest}} values are positive.
https://github.com/apache/solr/blob/releases/solr/9.6.1/solr/core/src/java/org/apache/solr/update/PeerSync.java#L876
was:
Noticed whilst code reading that the
{code}
...
if (ourLowThreshold > otherHigh && ourHighest >= otherHighest) {
...
{code}
comparison e.g.
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.10.0/solr/core/src/java/org/apache/solr/update/PeerSync.java#L792
presumes that the {{Highest}} values are positive.
> PeerSync inconsistently handles 'delete' highest versions
> ---------------------------------------------------------
>
> Key: SOLR-15689
> URL: https://issues.apache.org/jira/browse/SOLR-15689
> Project: Solr
> Issue Type: Bug
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Noticed whilst code reading that the
> {code}
> ...
> if (ourLowThreshold > otherHigh && ourHighest >= otherHighest) {
> ...
> {code}
> comparison e.g.
> https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.10.0/solr/core/src/java/org/apache/solr/update/PeerSync.java#L792
> presumes that the {{Highest}} values are positive.
> https://github.com/apache/solr/blob/releases/solr/9.6.1/solr/core/src/java/org/apache/solr/update/PeerSync.java#L876
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
