dsmiley commented on code in PR #2538:
URL: https://github.com/apache/solr/pull/2538#discussion_r1685239454


##########
solr/core/src/java/org/apache/solr/util/stats/MetricUtils.java:
##########
@@ -827,7 +845,7 @@ public static <T extends PlatformManagedObject> void 
addMXBeanMetrics(
       try {
         final Class<? extends PlatformManagedObject> intf =
             Class.forName(clazz).asSubclass(PlatformManagedObject.class);
-        MetricUtils.addMXBeanMetrics(obj, intf, null, consumer);
+        MetricUtils.addMXBeanMetrics(obj, intf, prefix, consumer);

Review Comment:
   What's this about here; seems like metrics would be published in a different 
spot, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to