[
https://issues.apache.org/jira/browse/SOLR-17344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867799#comment-17867799
]
Eric Pugh commented on SOLR-17344:
----------------------------------
I am looking at adding this, and sort of getting the "this is a lot of work..."
feeling... To do it comprehensively... Maybe if we had STARTED with this
when we kicked off the migration it would have been worth it... But since
this is for code that is going to be removed in 10x, maybe it's just not worth
it. I did add a unit test for both single and double dash..... Maybe if we
see bugs around this THEN we add it?
> Randomize short/long opts usage in Java-based CLI tests
> -------------------------------------------------------
>
> Key: SOLR-17344
> URL: https://issues.apache.org/jira/browse/SOLR-17344
> Project: Solr
> Issue Type: Sub-task
> Components: scripts and tools
> Affects Versions: main (10.0)
> Reporter: Jason Gerlowski
> Priority: Minor
>
> We have a decent suite of Java tests that validate "bin/solr" usage,
> including (but not limited to):
> * AuthToolTest
> * CreateToolTest
> * DeleteToolTest
> * PackageToolTest
> * HealthcheckToolTest
> * SolrCLIZkToolsTest
> Each of these tests triggers a tool with a (mostly hardcoded) set of
> string-literal parameters, e.g.
> {code}
> String[] args = {
> "auth",
> "enable",
> "-z",
> cluster.getZkClient().getZkServerAddress(),
> "--auth-conf-dir",
> dir.toAbsolutePath().toString(),
> "--solr-include-file",
> solrIncludeFile.toAbsolutePath().toString(),
> "-credentials",
> "solr:solr",
> "--block-unknown",
> "true"
> };
> assertEquals(0, runTool(args));
> {code}
> Randomizing the parameter names in these invocations would give us better
> coverage, and increase our confidence when making changes to the CLI syntax
> (like that done in SOLR-16824)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
