janhoy commented on code in PR #2580:
URL: https://github.com/apache/solr/pull/2580#discussion_r1687258156
##########
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##########
@@ -59,6 +60,26 @@ public String getName() {
return "auth";
}
+ @Override
+ public String getUsage() {
Review Comment:
Looks to be as intended, yea. DId not compile the PR to print the help
though.
##########
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##########
@@ -59,6 +59,16 @@ public String getName() {
return "delete";
}
+ @Override
+ public String getHeader() {
+ return "\nDeletes a core or collection depending on whether Solr is
running in standalone (core) or SolrCloud"
+ + " mode (collection). If you're deleting a collection in SolrCloud
mode, the default behavior is to also"
+ + " delete the configuration directory from Zookeeper so long as it is
not being used by another collection.\n"
+ + " You can override this behavior by passing -deleteConfig false when
running this command.\n"
+ + "\n"
+ + "List of options:";
Review Comment:
Yea, guess that's how commons-cli works. We could of course append that
"List of options:" string in SolrCLI so tools only need to provide the text
itself...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
