malliaridis commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1688763185
##########
solr/packaging/test/test_adminconsole_urls.bats:
##########
@@ -25,7 +25,7 @@ teardown() {
# save a snapshot of SOLR_HOME for failed tests
save_home_on_failure
- solr stop -all >/dev/null 2>&1
+ solr stop --all >/dev/null 2>&1
Review Comment:
I think adding tests in addition that checks that both still work is a good
idea.
As far as I understand, the function "teardown" is responsible for test
cleanup, so I guess it can be updated without problems? Or is there a chance
that the test will be executed with a version that does not support `--all`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
