cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1689976431
##########
solr/core/src/test/org/apache/solr/search/TestFiltering.java:
##########
@@ -92,21 +93,34 @@ public void testLiveDocsSharing() throws Exception {
QueryResult res = new QueryResult();
searcher.search(res, cmd);
set = res.getDocSet();
- assertSame(set, live);
+ assertEffectivelySame(set.getFixedBitSet(), live.getFixedBitSet());
cmd.setQuery(QParser.getParser(qstr + " OR id:0", null,
req).getQuery());
cmd.setFilterList(QParser.getParser(qstr + " OR id:1", null,
req).getQuery());
res = new QueryResult();
searcher.search(res, cmd);
set = res.getDocSet();
- assertSame(set, live);
+ assertEffectivelySame(set.getFixedBitSet(), live.getFixedBitSet());
}
} finally {
req.close();
}
}
+ /** If the a XOR b == 0, then both a & b are effectively the same bitset */
+ private void assertEffectivelySame(FixedBitSet a, FixedBitSet b) {
Review Comment:
It seems the change is no longer needed now, #2589 proposes to revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
