magibney commented on code in PR #2591:
URL: https://github.com/apache/solr/pull/2591#discussion_r1691502929
##########
solr/core/src/java/org/apache/solr/metrics/MetricSuppliers.java:
##########
@@ -154,17 +155,25 @@ public static Clock getClock(PluginInfo info, String
param) {
private static final String EDR_CLAZZ =
ExponentiallyDecayingReservoir.class.getName();
private static final String UNI_CLAZZ = UniformReservoir.class.getName();
private static final String STW_CLAZZ =
SlidingTimeWindowReservoir.class.getName();
+ private static final String STWA_CLAZZ =
SlidingTimeWindowArrayReservoir.class.getName();
Review Comment:
I noticed there's no support for the new `SlidingTimeWindowArrayReservoir`
class, so I added it here. See [dropwizard
docs](https://metrics.dropwizard.io/4.2.0/manual/core.html#sliding-time-window-reservoirs):
> Hint: Try to use our new optimised version of `SlidingTimeWindowReservoir`
called `SlidingTimeWindowArrayReservoir`. It brings much lower memory overhead.
Also it’s allocation/free patterns are different, so GC overhead is 60x-80x
lower then `SlidingTimeWindowReservoir`. Now `SlidingTimeWindowArrayReservoir`
is comparable with `ExponentiallyDecayingReservoir` in terms GC overhead and
performance. As for required memory, `SlidingTimeWindowArrayReservoir` takes
~128 bits per stored measurement and you can simply calculate required amount
of heap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
