dsmiley commented on code in PR #2595:
URL: https://github.com/apache/solr/pull/2595#discussion_r1693381153
##########
solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java:
##########
@@ -313,6 +340,37 @@ public MDCAwareThreadPoolExecutor(
RejectedExecutionHandler handler) {
super(corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue,
handler);
this.enableSubmitterStackTrace = true;
+ this.beforeExecuteTask = NOOP;
+ }
+
+ public MDCAwareThreadPoolExecutor(
+ int corePoolSize,
+ int maximumPoolSize,
+ int keepAliveTime,
+ TimeUnit timeUnit,
+ BlockingQueue<Runnable> blockingQueue,
+ SolrNamedThreadFactory httpShardExecutor,
+ boolean enableSubmitterStackTrace) {
+ super(
+ corePoolSize, maximumPoolSize, keepAliveTime, timeUnit,
blockingQueue, httpShardExecutor);
+ this.enableSubmitterStackTrace = enableSubmitterStackTrace;
+ this.beforeExecuteTask = NOOP;
+ }
+
+ public MDCAwareThreadPoolExecutor(
+ int i,
+ int maxValue,
+ long l,
+ TimeUnit timeUnit,
+ BlockingQueue<Runnable> es,
+ SolrNamedThreadFactory testExecutor,
+ boolean b) {
+ this(i, maxValue, l, timeUnit, es, testExecutor, b, NOOP);
+ }
+
+ @Override
+ protected void beforeExecute(Thread t, Runnable r) {
+ super.beforeExecute(t, this.beforeExecuteTask);
Review Comment:
super.beforeExecute doesn't do anything; it's a callback -- something the
underlying ThreadPoolExecutor will call, not something we should call..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
