dsmiley commented on code in PR #2596:
URL: https://github.com/apache/solr/pull/2596#discussion_r1696053704
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -1921,8 +1921,11 @@ public ScoreMode scoreMode() {
final TopDocs topDocs;
final ScoreMode scoreModeUsed;
if (!MultiThreadedSearcher.allowMT(pf.postFilter, cmd, query)) {
- if (log.isDebugEnabled()) {
- log.debug("skipping collector manager");
+ if (cmd.getMultiThreaded() != null) {
+ // report multi-threading (non-)use only if multi-threading was
explicitly (not) requested
Review Comment:
Would this replacement be accurate:
"(not) requested" -> "disabled"
If so, it's clearer to me.
##########
solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc:
##########
@@ -400,6 +400,16 @@ If early termination is used, a `segmentTerminatedEarly`
header will be included
Similar to using <<timeAllowed Parameter,the `timeAllowed` Parameter>>, when
early segment termination happens values such as `numFound`,
xref:faceting.adoc[Facet] counts, and result xref:stats-component.adoc[Stats]
may not be accurate for the entire result set.
+== multiThreaded Parameter
+
+[%autowidth,frame=none]
+|===
+|Optional |Default: `false`
+|===
+
+If unset or set to `false`, then the multi-threaded search implementation will
not be used for the query.
+If set to `true`, then use the multi-threaded search implementation if it is
supported for the query.
Review Comment:
I could see us using this parameter in the future for indexing.
##########
solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc:
##########
@@ -400,6 +400,16 @@ If early termination is used, a `segmentTerminatedEarly`
header will be included
Similar to using <<timeAllowed Parameter,the `timeAllowed` Parameter>>, when
early segment termination happens values such as `numFound`,
xref:faceting.adoc[Facet] counts, and result xref:stats-component.adoc[Stats]
may not be accurate for the entire result set.
+== multiThreaded Parameter
+
+[%autowidth,frame=none]
+|===
+|Optional |Default: `false`
+|===
+
+If unset or set to `false`, then the multi-threaded search implementation will
not be used for the query.
+If set to `true`, then use the multi-threaded search implementation if it is
supported for the query.
Review Comment:
Suggested simple wording:
> 'true' or 'false' controls if Solr may use more than one thread to satisfy
the request.
> It presently is only considered for `QueryComponent` to search across
Lucene's segments in parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
