[
https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869660#comment-17869660
]
Gus Heck commented on SOLR-17298:
---------------------------------
[~ichattopadhyaya] What was your reason for disallowing RankQuery, GraphQuery
and JoinQuery? Tests seem to pass with the check commented out:
{code:java}
private static class MTCollectorQueryCheck extends QueryVisitor {
private QueryVisitor subVisitor = this;
private boolean allowMt(Query query) {
// if (query instanceof RankQuery || query instanceof GraphQuery ||
query instanceof
// JoinQuery) {
// return false;
// }
return true;
}
...
{code}
> Multithreaded search breaks limits, and possibly other things
> -------------------------------------------------------------
>
> Key: SOLR-17298
> URL: https://issues.apache.org/jira/browse/SOLR-17298
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: main (10.0), 9.7, 9x
> Reporter: Gus Heck
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 9.7
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/SOLR-13350 was merged to main somewhat
> unexpectedly, and then back-ported to 9x without any response to feedback
> from multiple committers, including feedback that
> * By turning it on by default, it breaks the recently released CPU limits
> (as shown by changes to unit tests).
> * Incompatibility with timeAllowed, cpuTimeAllowed, segmentTerminateEarly,
> GraphQuery, RankQuery and JoinQuery was not clearly documented
> * The code presents a possibility for users to receive a non-numeric max
> score ("NaN").
> I have not verified it yet, but I would also be worried about the health of
> CPU time logging to be added in
> https://issues.apache.org/jira/browse/SOLR-16986 after this change.
> Given that:
> * Some of the above issues represent back compatibility breaks or potential
> back compatibility breaks for released features
> * The decision to break compatibility within the 9x release series deserves
> a formal vote (or a fix).
> * There has been no communication/response from the committer who merged
> these changes since May 6 (aside from the backport to 9x on May 13) it seems
> that this state may persist for some time.
> Therefore it appears necessary to file this issue to ensure anything but a
> 9.6.1 is blocked until the above issues are sorted out. This ticket can serve
> as a parent ticket to whatever various solutions are agreed upon.
> Multi-threaded search is an awesome feature that has taken a very long time
> to be realized and is obviously desirable, but we have now placed ourselves
> in an awkward position by not resolving these last few issues before back
> porting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
