aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1702289620
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ClusterStateProvider.java:
##########
@@ -107,9 +111,15 @@ default DocCollection getCollection(String name) throws
IOException {
/** Obtain a cluster property, or the default value if it doesn't exist. */
default <T> T getClusterProperty(String key, T defaultValue) {
+ Map<String, Object> properties = getClusterProperties();
+ if (properties == null) {
+ return defaultValue;
+ }
@SuppressWarnings({"unchecked"})
- T value = (T) getClusterProperties().get(key);
- if (value == null) return defaultValue;
+ T value = (T) properties.get(key);
Review Comment:
Done
##########
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##########
@@ -45,7 +45,11 @@
public class ClusterStatus {
private final ZkStateReader zkStateReader;
private final ZkNodeProps message;
- private final String collection; // maybe null
+ private final String collectionParam; // maybe null
+ private final boolean liveNodesParam;
+ private final boolean clusterPropertiesParam;
+ private final boolean rolesParam;
+ private final boolean includeAll;
Review Comment:
Addressed in latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
