dsmiley commented on code in PR #2588:
URL: https://github.com/apache/solr/pull/2588#discussion_r1705495049
##########
solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java:
##########
@@ -116,7 +116,7 @@ SearchResult searchCollectorManagers(
ScoreMode scoreMode = SolrMultiCollectorManager.scoreMode(firstCollectors);
- return new SearchResult(scoreMode, ret);
+ return new SearchResult(scoreMode, ret, needTopDocs, needMaxScore,
needDocSet);
Review Comment:
granted a trio of booleans is hard to interpret at the call-sight in Java
but at least an IDE nowadays shows the names. This problem already started at
`MulitThreadedSeacher.searchCollectorManagers()` (where this is more of a
concern as it's called by SolrIndexSearcher) so here you just follow-suit, I
understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
