dsmiley commented on code in PR #2619:
URL: https://github.com/apache/solr/pull/2619#discussion_r1705975931


##########
solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java:
##########
@@ -243,15 +243,27 @@ public static ExecutorService 
newMDCAwareCachedThreadPool(ThreadFactory threadFa
         0, Integer.MAX_VALUE, 60L, TimeUnit.SECONDS, new SynchronousQueue<>(), 
threadFactory);
   }
 
+  /**

Review Comment:
   Suggested:
   > Create a new pool of threads.  Threads are created for new work if there 
is room to do so up to {@code maxThreads}.  Beyond that, the queue is used up 
to {@code queueCapacity}.  Beyond that, work is rejected with an exception.  
Unused threads will be closed after 60 seconds.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to