malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708121034
##########
solr/server/etc/jetty.xml:
##########
@@ -95,7 +95,7 @@
<New class="org.eclipse.jetty.rewrite.handler.HeaderPatternRule">
<Set name="pattern">/solr/*</Set>
<Set name="name">Content-Security-Policy</Set>
- <Set name="value">default-src 'none'; base-uri 'none'; connect-src
'self'; form-action 'self'; font-src 'self'; frame-ancestors 'none'; img-src
'self' data:; media-src 'self'; style-src 'self' 'unsafe-inline'; script-src
'self'; worker-src 'self';</Set>
+ <Set name="value">default-src 'none'; base-uri 'none'; connect-src
'self'; form-action 'self'; font-src 'self'; frame-ancestors 'none'; img-src
'self' data:; media-src 'self'; style-src 'self' 'unsafe-inline'; script-src
'self' 'wasm-unsafe-eval'; worker-src 'self';</Set>
Review Comment:
Good thing you pointed this line out. This is one of the security
"considerations" that are necessary when introducing a wasm application to our
current UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
