dsmiley commented on code in PR #2629:
URL: https://github.com/apache/solr/pull/2629#discussion_r1709925772
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -55,7 +56,8 @@ public abstract class BaseHttpClusterStateProvider implements
ClusterStateProvid
volatile Map<String, Map<String, String>> aliasProperties;
long aliasesTimestamp = 0;
- private int cacheTimeout = 5; // the liveNodes and aliases cache will be
invalidated after 5 secs
+ // the liveNodes and aliases cache will be invalidated after 5 secs
+ private int cacheTimeout =
EnvUtils.getPropertyAsInteger("solr.httpcsp.cache.timeout", 5);
Review Comment:
This is specific to SolrJ and people don't know what "httpcsp" is. Only in
the last week did you and I start doing that abbreviation.
`solr.solrj.cache.timeout` and assume milliseconds thus 5000 value (that's
the default assumption when units don't clarify)
FYI CloudSolrClient has a cache of DocCollection which has a separate
timeout and there's no EnvUtils for that. So I suppose this is okay to
introduce in this PR a very general sounding thing so long as it doesn't mean
there might be something more specific with its own timeout. It's tempting to
suggest adding "livenodes" as a name component above but it's both live nodes
and aliases, which is awkward. I'd be okay with that as well, if we think
aliases might disappear as an explicit cacheable concern here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
