epugh commented on code in PR #2381:
URL: https://github.com/apache/solr/pull/2381#discussion_r1712676449
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -310,6 +310,12 @@ private static Tool newTool(String toolType) throws
Exception {
else if ("post".equals(toolType)) return new PostTool();
else if ("postlogs".equals(toolType)) return new PostLogsTool();
else if ("version".equals(toolType)) return new VersionTool();
+ else if ("snapshot-create".equals(toolType)) return new
SnapshotCreateTool();
+ else if ("snapshot-delete".equals(toolType)) return new
SnapshotDeleteTool();
+ else if ("snapshot-list".equals(toolType)) return new SnapshotListTool();
+ else if ("snapshot-describe".equals(toolType)) return new
SnapshotDescribeTool();
+ else if ("snapshot-prepare-export".equals(toolType)) return new
SnapshotPrepareExportTool();
+ else if ("snapshot-export".equals(toolType)) return new
SnapshotExportTool();
Review Comment:
Right now how we handle the zk logic, and how we handle the snapshots, and
how we handle subcommands in the package tool and the auth tool all are a bit
different! I do hope we can get to a single stronger pattern! Seperate
ticket, but defnitly needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
