[
https://issues.apache.org/jira/browse/SOLR-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876667#comment-17876667
]
Eric Pugh commented on SOLR-3913:
---------------------------------
[~dsmiley] i am fixing the first commit/optimize optimization option.. the
second one, can you repoint me? I searched for "buffer" and didn't find an
obvious point that you mentioned over a decade ago ;).
> SimplePostTool optimize does a redundant commit
> -----------------------------------------------
>
> Key: SOLR-3913
> URL: https://issues.apache.org/jira/browse/SOLR-3913
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Reporter: David Smiley
> Assignee: Eric Pugh
> Priority: Minor
>
> At the end of SimplePostTool.execute() there is:
> {code}
> if (commit) commit();
> if (optimize) optimize();
> {code}
> Each of these calls involves a separate request to Solr. The thing is, an
> optimize internally commits, and so the logic should forgo committing is
> optimize is true.
> And as an aside, I think the 1kb pipe() buffer on line 893 is too small; it
> should be around 8kb (8192) bytes which is the same value as
> BufferedInputStream's default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
