epugh commented on code in PR #2690:
URL: https://github.com/apache/solr/pull/2690#discussion_r1742692112
##########
solr/core/src/java/org/apache/solr/cli/ConfigTool.java:
##########
@@ -93,9 +109,13 @@ public void runImpl(CommandLine cli) throws Exception {
String solrUrl = SolrCLI.normalizeSolrUrl(cli);
String action = cli.getOptionValue("action", "set-property");
String collection = cli.getOptionValue("name");
- String property = cli.getOptionValue("property");
+ String property = SolrCLI.getOptionWithDeprecatedAndDefault(cli,
"property", "p", null);
String value = cli.getOptionValue("value");
+ if (property == null) {
+ throw new IllegalArgumentException("'property' is a required option.");
Review Comment:
why not!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
