epugh commented on code in PR #2700:
URL: https://github.com/apache/solr/pull/2700#discussion_r1750228899
##########
solr/core/src/test/org/apache/solr/search/TestMinHashQParser.java:
##########
@@ -417,8 +417,7 @@ public void testBandsWrap() throws SyntaxError {
QParser qparser =
h.getCore()
.getQueryPlugin("minhash")
- .createParser(
- "1, 2, 3, 4, 5, 6, 7, 8, 9, 10", SolrParams.toSolrParams(par),
null, null);
+ .createParser("1, 2, 3, 4, 5, 6, 7, 8, 9, 10", par.toSolrParams(),
null, null);
Review Comment:
"par"? Sort of a nitpick, but maybe a more descriptive variable name?
"params'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
