[ 
https://issues.apache.org/jira/browse/SOLR-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880449#comment-17880449
 ] 

Chris M. Hostetter commented on SOLR-7122:
------------------------------------------

{quote}would you mind revalidating this? I can't believe this still exists!
{quote}
It's pretty trivial to check :)

 

Most of them seem fixed (probably due to how/where file permissions are 
recorded in git vs the old svn repo) but it does seem wrong that 
{{solr/bin/init.d/solr}} is still not executable?

 

I also have no idea if {{CMD}} or {{BAT}} files should be executable in our tgz 
releases?  ( {{solr.cmd}} is executable, but {{solr-exporter.cmd}} and 
{{zkcli.bat}} are not )

 
{noformat}
hossman@slate:~/tmp$ curl -L --output solr-9.6.1-src.tgz 
'https://www.apache.org/dyn/closer.lua/solr/solr/9.6.1/solr-9.6.1-src.tgz?action=download'
...

hossman@slate:~/tmp$ tar -tzvf solr-9.6.1-src.tgz | grep -F -e /bin/ -e 
/cloud-scripts/
drwxrwxr-x root/root         0 2024-05-23 10:59 solr-9.6.1/solr/bin/
drwxrwxr-x root/root         0 2024-05-23 10:59 solr-9.6.1/solr/bin/init.d/
-rw-rw-r-- root/root      2720 2024-05-23 10:59 solr-9.6.1/solr/bin/init.d/solr
-rwxrwxr-x root/root     12148 2024-05-23 10:59 
solr-9.6.1/solr/bin/install_solr_service.sh
-rwxrwxr-x root/root      8335 2024-05-23 10:59 solr-9.6.1/solr/bin/post
-rwxrwxr-x root/root      1736 2024-05-23 10:59 solr-9.6.1/solr/bin/postlogs
-rwxrwxr-x root/root     95894 2024-05-23 10:59 solr-9.6.1/solr/bin/solr
-rwxrwxr-x root/root     80679 2024-05-23 10:59 solr-9.6.1/solr/bin/solr.cmd
-rwxrwxr-x root/root     14408 2024-05-23 10:59 solr-9.6.1/solr/bin/solr.in.cmd
-rw-rw-r-- root/root     15598 2024-05-23 10:59 solr-9.6.1/solr/bin/solr.in.sh
drwxrwxr-x root/root         0 2024-05-23 10:59 
solr-9.6.1/solr/prometheus-exporter/bin/
-rwxrwxr-x root/root      4032 2024-05-23 10:59 
solr-9.6.1/solr/prometheus-exporter/bin/solr-exporter
-rw-rw-r-- root/root      3707 2024-05-23 10:59 
solr-9.6.1/solr/prometheus-exporter/bin/solr-exporter.cmd
drwxrwxr-x root/root         0 2024-05-23 10:59 
solr-9.6.1/solr/server/scripts/cloud-scripts/
-rwxrwxr-x root/root      4548 2024-05-23 10:59 
solr-9.6.1/solr/server/scripts/cloud-scripts/snapshotscli.sh
-rw-rw-r-- root/root      1278 2024-05-23 10:59 
solr-9.6.1/solr/server/scripts/cloud-scripts/zkcli.bat
-rwxrwxr-x root/root      1156 2024-05-23 10:59 
solr-9.6.1/solr/server/scripts/cloud-scripts/zkcli.sh

hossman@slate:~/tmp$ tar -tzvf solr-9.6.1-src.tgz | grep -F -e /bin/ -e 
/cloud-scripts/ | grep -v 'rwx'
-rw-rw-r-- root/root      2720 2024-05-23 10:59 solr-9.6.1/solr/bin/init.d/solr
-rw-rw-r-- root/root     15598 2024-05-23 10:59 solr-9.6.1/solr/bin/solr.in.sh
-rw-rw-r-- root/root      3707 2024-05-23 10:59 
solr-9.6.1/solr/prometheus-exporter/bin/solr-exporter.cmd
-rw-rw-r-- root/root      1278 2024-05-23 10:59 
solr-9.6.1/solr/server/scripts/cloud-scripts/zkcli.bat
 {noformat}

> bin scripts don't have executable permissions in src releases
> -------------------------------------------------------------
>
>                 Key: SOLR-7122
>                 URL: https://issues.apache.org/jira/browse/SOLR-7122
>             Project: Solr
>          Issue Type: Bug
>          Components: scripts and tools
>    Affects Versions: 4.10, 5.0
>            Reporter: Chris M. Hostetter
>            Priority: Minor
>             Fix For: 5.2, 6.0
>
>
> if you download a tgz source release and build Solr yourself, the various 
> scripts (eg: bin/solr, bin/post, server/scripts/cloud-scripts/zkcli.sh, 
> etc..) don't have the executable bit set so they can't be run from shell.
> chmod a+x is easy to run, but we see about getting these filesys props set 
> properly inside the tgz file...
> {noformat}
> $ tar tzvf solr-5.0.0-src.tgz | grep /solr/bin/
> drwxr-xr-x 0/0               0 2015-02-15 13:24 solr-5.0.0/solr/bin/
> drwxr-xr-x 0/0               0 2015-02-15 13:24 solr-5.0.0/solr/bin/init.d/
> -rw-r--r-- 0/0            2689 2014-12-23 16:20 
> solr-5.0.0/solr/bin/init.d/solr
> -rw-r--r-- 0/0            8293 2015-01-21 10:04 
> solr-5.0.0/solr/bin/install_solr_service.sh
> -rw-r--r-- 0/0            1255 2014-12-24 08:59 
> solr-5.0.0/solr/bin/oom_solr.sh
> -rw-r--r-- 0/0            7371 2015-01-21 19:07 solr-5.0.0/solr/bin/post
> -rw-r--r-- 0/0           54757 2015-01-30 18:46 solr-5.0.0/solr/bin/solr
> -rw-r--r-- 0/0           47656 2015-02-09 08:08 solr-5.0.0/solr/bin/solr.cmd
> -rw-r--r-- 0/0            4143 2015-01-15 11:43 
> solr-5.0.0/solr/bin/solr.in.cmd
> -rw-r--r-- 0/0            4424 2015-01-15 11:43 solr-5.0.0/solr/bin/solr.in.sh
> $ tar tzvf solr-5.0.0-src.tgz | grep server/scripts/cloud-scripts/
> drwxr-xr-x 0/0               0 2015-02-15 13:24 
> solr-5.0.0/solr/server/scripts/cloud-scripts/
> -rw-r--r-- 0/0             317 2013-05-10 15:29 
> solr-5.0.0/solr/server/scripts/cloud-scripts/log4j.properties
> -rw-r--r-- 0/0             707 2014-07-14 10:31 
> solr-5.0.0/solr/server/scripts/cloud-scripts/zkcli.bat
> -rw-r--r-- 0/0             485 2014-05-29 06:05 
> solr-5.0.0/solr/server/scripts/cloud-scripts/zkcli.sh
> {noformat}
> compare to the non-src release...
> {noformat}
> $ tar tzvf solr-5.0.0.tgz | grep /bin/
> drwxr-xr-x 0/0               0 2015-02-15 12:38 solr-5.0.0/bin/
> drwxr-xr-x 0/0               0 2015-02-15 12:38 solr-5.0.0/bin/init.d/
> -rwxr-xr-x 0/0            2689 2015-02-15 12:38 solr-5.0.0/bin/init.d/solr
> -rwxr-xr-x 0/0            8293 2015-02-15 12:38 
> solr-5.0.0/bin/install_solr_service.sh
> -rwxr-xr-x 0/0            1255 2015-02-15 12:38 solr-5.0.0/bin/oom_solr.sh
> -rwxr-xr-x 0/0            7371 2015-02-15 12:38 solr-5.0.0/bin/post
> -rwxr-xr-x 0/0           54757 2015-02-15 12:38 solr-5.0.0/bin/solr
> -rwxr-xr-x 0/0           47656 2015-02-15 12:38 solr-5.0.0/bin/solr.cmd
> -rwxr-xr-x 0/0            4143 2015-02-15 12:38 solr-5.0.0/bin/solr.in.cmd
> -rwxr-xr-x 0/0            4424 2015-02-15 12:38 solr-5.0.0/bin/solr.in.sh
> $ tar tzvf solr-5.0.0.tgz | grep server/scripts/cloud-scripts/
> drwxr-xr-x 0/0               0 2015-02-15 12:38 
> solr-5.0.0/server/scripts/cloud-scripts/
> -rw-r--r-- 0/0             317 2015-02-15 12:38 
> solr-5.0.0/server/scripts/cloud-scripts/log4j.properties
> -rw-r--r-- 0/0             707 2015-02-15 12:38 
> solr-5.0.0/server/scripts/cloud-scripts/zkcli.bat
> -rwxr-xr-x 0/0             485 2015-02-15 12:38 
> solr-5.0.0/server/scripts/cloud-scripts/zkcli.sh
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to