cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1755053664
##########
solr/core/src/test/org/apache/solr/cloud/ReplicateFromLeaderTest.java:
##########
@@ -18,54 +18,94 @@
package org.apache.solr.cloud;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertThrows;
+import org.apache.solr.common.SolrException;
import org.apache.solr.core.SolrConfig;
+import org.junit.After;
+import org.junit.Before;
import org.junit.Test;
public class ReplicateFromLeaderTest {
+ private String jettyTestMode;
+
+ @Before
+ public void setUp() {
+ jettyTestMode = System.getProperty("jetty.testMode");
+ System.clearProperty("jetty.testMode");
+ }
+
+ @After
+ public void tearDown() {
+ if (jettyTestMode != null) {
+ System.setProperty("jetty.testMode", jettyTestMode);
+ }
+ }
+
Review Comment:
Would retaining existing behaviour --
https://github.com/apache/solr/pull/2316/files#r1755039181 -- mean that we
don't have to make this test change here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
