dsmiley commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1758798912
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -729,14 +729,16 @@ public void preClose() {
try {
synchronized (collectionToTerms) {
- customThreadPool.submit(
- () ->
collectionToTerms.values().parallelStream().forEach(ZkCollectionTerms::close));
+ collectionToTerms
+ .values()
+ .forEach(zkCollectionTerms ->
customThreadPool.execute(zkCollectionTerms::close));
}
- customThreadPool.submit(
- () ->
- replicateFromLeaders.values().parallelStream()
- .forEach(ReplicateFromLeader::stopReplication));
+ replicateFromLeaders
+ .values()
+ .forEach(
+ replicateFromLeader ->
+
customThreadPool.execute(replicateFromLeader::stopReplication));
Review Comment:
I think parallelStream waited for the results to finish, but your change
doesn't wait.
##########
solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java:
##########
@@ -936,7 +936,7 @@ private void testNewSingleFileAfterSchemaAPI(boolean v2)
throws Exception {
String collectionName = "newcollection";
String configsetName = "regular";
String configsetSuffix = "testSinglePathNew-1-" + v2;
- createConfigSet(null, configsetName + configsetSuffix, null,
cluster.getSolrClient(), "solr");
+ uploadConfigSetWithAssertions(configsetName, configsetSuffix, "solr");
Review Comment:
isn't createConfigSet synchronous? What does this PR perturb to cause this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
