dsmiley commented on PR #2687: URL: https://github.com/apache/solr/pull/2687#issuecomment-2351370178
When I run the agent, I provide an Otel properties file with: (an excerpt) ``` otel.metrics.exporter=none otel.logs.exporter=none otel.instrumentation.common.default-enabled=false otel.instrumentation.opentelemetry-api.enabled=true otel.instrumentation.opentelemetry-instrumentation-annotations.enabled=true otel.instrumentation.aws-sdk.enabled=true otel.instrumentation.java-http-client.enabled=true ``` Notice I disable auto-instrumentation by default and selectively enable the specific instrumentations useful to me. This works with Solr's manual instrumentation of itself as well because of enabling "opentelemetry-api". All this is documented quite well in Otel. I don't see how this PR would have unintentional changes on existing traces/spans since they are tested and the PR doesn't change them. Any way, I'm happy to share a screenshot later. This PR misses documentation to let users know they don't have to enable the opentelemetry module just to use opentelemetry :-). (an aside -- nor do we tell users they don't have to have an HDFS cluster to make use of the HDFS Directory). Also I'd like to somewhere document a tip on how to use tracing during development / debugging of a unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
