malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775109063
##########
build.gradle:
##########
@@ -139,7 +143,7 @@ apply from: file('gradle/maven/defaults-maven.gradle')
// IDE support, settings and specials.
apply from: file('gradle/ide/intellij-idea.gradle')
-apply from: file('gradle/ide/eclipse.gradle')
+// apply from: file('gradle/ide/eclipse.gradle')
Review Comment:
Good catch, this slipt into the PR without me noticing it before I create
the PR. I have to see if I can build the project with the `eclipse.gradle` file
loaded, it caused some issues on my environment.
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/SolrZkClient.java:
##########
@@ -85,7 +85,7 @@ public class SolrZkClient implements Closeable {
private int minStateByteLenForCompression;
public MapWriter getMetrics() {
- return metrics::writeMap;
+ return metrics;
Review Comment:
It was causing linting errors in the CI/CD, but not locally, which is why I
had to fix it. Same case for `p::writeMap` in another commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
