gerlowskija commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1778725864
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -533,6 +534,25 @@ public NamedList<Object> request(SolrRequest<?>
solrRequest, String collection)
}
}
+ public <R> R requestWithBaseUrl(String baseUrl,
SolrClientFunction<SolrClient, R> clientFunction)
Review Comment:
Conceptually, it probably makes sense for this method to be available on all
of our "Http" clients. But in practice, only Http2SolrClient makes it easy to
quickly clone an existing instance, which this method implementation leans on
pretty heavily.
Ambivalent on whether this is worth the effort to make available more
widely. Curious what others think...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
