dsmiley commented on code in PR #2751:
URL: https://github.com/apache/solr/pull/2751#discussion_r1794502983
##########
solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java:
##########
@@ -290,15 +290,15 @@ public SimpleSolrResponse invoke(String solrNode, String
path, SolrParams params
String url =
zkClientClusterStateProvider.getZkStateReader().getBaseUrlForNodeName(solrNode);
GenericSolrRequest request = new
GenericSolrRequest(SolrRequest.METHOD.POST, path, params);
- try (var client =
- new HttpSolrClient.Builder()
- .withHttpClient(solrClient.getHttpClient())
- .withBaseSolrUrl(url)
- .withResponseParser(new BinaryResponseParser())
- .build()) {
- NamedList<Object> rsp = client.request(request);
+ request.setResponseParser(new BinaryResponseParser());
+
+ try {
+ NamedList<Object> rsp =
+ cloudSolrClient.getHttpClient().requestWithBaseUrl(url,
request::process).getResponse();
Review Comment:
instead of a method reference, why not pass request itself (the method is
overloaded)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
