epugh commented on code in PR #2754:
URL: https://github.com/apache/solr/pull/2754#discussion_r1797712401
##########
solr/bin/solr.cmd:
##########
@@ -1520,7 +1521,9 @@ for %%a in (%*) do (
) else (
set "option!option!=%%a"
if "!option!" equ "-d" set "SOLR_SERVER_DIR=%%a"
+ if "!option!" equ "--server-dir" set "SOLR_SERVER_DIR=%%a"
if "!option!" equ "-s" set "SOLR_HOME=%%a"
+ if "!option!" equ "--solr-home" set "SOLR_HOME=%%a"
if not "!option!" equ "-s" if not "!option!" equ "-d" (
set "AUTH_PARAMS=!AUTH_PARAMS! !option! %%a"
)
Review Comment:
Yeah, good darn question. I also think we have extra options parsing in the
`.cmd` that doesn't exist in `bin/solr`... I think we have places where we
could be leaning more on the existing java parsing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
