[
https://issues.apache.org/jira/browse/SOLR-17488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888913#comment-17888913
]
Christos Malliaridis commented on SOLR-17488:
---------------------------------------------
Right now, the user has to provide a flag with a "negative" value
({{\-\-delete-config false}}) in order to disable the deletion and keep
something. Deleting is a change that cannot be undone without enough effort, so
it should be at least easier to disable the deletion by using a single option
without values. I am fine with using {{\-\-keep-config}}, but I would like to
get rid of flags that require a boolean value, and especially a negative
boolean, which is the case for {{\-\-delete-config}}.
It may be even better if the default behavior would be to keep the config, and
providing {{\-\-delete-config}} would delete it (explicitly). This would
probably be the best and safest behavior for the user as well.
> CLI: Resolve -d conflicts
> -------------------------
>
> Key: SOLR-17488
> URL: https://issues.apache.org/jira/browse/SOLR-17488
> Project: Solr
> Issue Type: Sub-task
> Components: cli
> Affects Versions: 9.7, 9.6.1
> Reporter: Christos Malliaridis
> Assignee: Eric Pugh
> Priority: Major
> Labels: cli, pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The CLI flag {{\-d}} is currently used in four options:
> - {{conf-dir}} for providing the configuration directory in CreateTool,
> ConfigSetDownloadTool, ConfigSetUploadTool, ZKCLI
> - {{delete-config}} (with argument) for deleting configurations together with
> collections in DeleteTool, defualts to {{true}}
> - {{server-dir}} for defining the Solr root / server directory in
> RunExampleTool
> - {{delay}} for delaying recursive posts in PostTool
> *Proposed Resolution*
> In order to avoid confusion of the {{\-d}} flag, the following changes are
> proposed:
> - keep {{\-d}} for {{conf-dir}} in CreateTool, ConfigSetDownloadTool,
> ConfigSetUploadTool, ZKCLI
> - Deprecated (9.8) and remove (10.0) the {{delete-config}} option by
> replacing it with {{keep}} ({{\-\-keep}} without arguments) for simplifying
> and improving user experience and avoid conflict of {{\-d}}. "{{\-\-keep}}"
> should behave equivalent to "{{\-\-delete-config false}}".
> - Deprecate (9.8) and remove (10.0) {{\-d}} for {{server-dir}} in
> RunExmapleTool. Note that {{\-\-server-dir}} may be removed or renamed to use
> better wording in the future.
> - Support {{\-\-server-dir}} in {{bin/solr}} and if necessary
> {{bin/solr.cmd}} in version 9.8 and 10.0
> - Deprecate (9.8) and remove (10.0) {{\-d}} for {{delay}} in PostTool to
> avoid any confusion with {{conf-dir}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
