dsmiley commented on PR #2763: URL: https://github.com/apache/solr/pull/2763#issuecomment-2418420895
Addressing your nit on renaming `_request` to `request` wasn't fully possible for various reasons at first, so I started pulling on that thread, doing some refactoring that ultimately led to me doing that rename. CC @gus-asf for review on my changes (commit messages explain what I did too). Happy to decouple such changes to another PR; it's out of scope. Granted the scope has been somewhat flexible, maybe too much... this started with me wondering, why can't we just use HttpServletRequest instead of the old ServletRequest. Oh hey look, we have some old base class that isn't what I expect, doing some old logging stuff that's obsolete / useless (IMO). So let's just subclass HttpFilter. An aside, the excludedPath thing seems bolted on and shouldn't have been added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
