[
https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant updated SOLR-17504:
----------------------------------
Description:
... and DirectUpdateHandler2.closeWriter supports commit metadata.
This proposal is about unifying calls to UpdateHandler.commit.
CoreContainer.reload may call directly IndexWriter.commit if the core to reload
is readonly (property of the Collection). This is an issue because it bypasses
some logic in UpdateHandler.commit. In addition, the current code commits
without taking the commit lock.
DirectUpdateHandler2.closeWriter may commit if the update log is not empty (not
committed yet). But it does not call DirectUpdateHandler2.commit(), it copies
commit() code instead for some reasons (comments in the code mention test
failures). The proposal is to add the same call to
DirectUpdateHandler2.shouldCommit() as in the commit() method, otherwise commit
metadata are lost. In addition shouldCommit() can be extended correctly, for
example in the solr-sandbox encryption module which needs to intercept calls to
shouldCommit().
was:
DirectUpdateHandler2.closeWriter may commit if the update log is not empty (not
committed yet). But it does not call DirectUpdateHandler2.commit(), it copies
commit() code instead for some reasons (comments in the code mention test
failures).
The proposal is to add the same call to DirectUpdateHandler2.shouldCommit() as
in the commit() method, otherwise commit metadata are lost. In addition
shouldCommit() can be extended correctly, for example in the solr-sandbox
encryption module which needs to intercept calls to shouldCommit().
> CoreContainer calls UpdateHandler.commit
> ----------------------------------------
>
> Key: SOLR-17504
> URL: https://issues.apache.org/jira/browse/SOLR-17504
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Bruno Roustant
> Priority: Major
>
> ... and DirectUpdateHandler2.closeWriter supports commit metadata.
> This proposal is about unifying calls to UpdateHandler.commit.
> CoreContainer.reload may call directly IndexWriter.commit if the core to
> reload is readonly (property of the Collection). This is an issue because it
> bypasses some logic in UpdateHandler.commit. In addition, the current code
> commits without taking the commit lock.
> DirectUpdateHandler2.closeWriter may commit if the update log is not empty
> (not committed yet). But it does not call DirectUpdateHandler2.commit(), it
> copies commit() code instead for some reasons (comments in the code mention
> test failures). The proposal is to add the same call to
> DirectUpdateHandler2.shouldCommit() as in the commit() method, otherwise
> commit metadata are lost. In addition shouldCommit() can be extended
> correctly, for example in the solr-sandbox encryption module which needs to
> intercept calls to shouldCommit().
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
