malliaridis opened a new pull request, #2787: URL: https://github.com/apache/solr/pull/2787
# Description This is the continuation of #2778, as it seems there are some special cases that cause URL parsing issues. # Solution The changes leverage jakarta's `UriBuilder` to avoid custom logic for URL path concatenation, which seems to cause some issues for cases where path segments like the `hostContext` may be `/`. Additionally, the currently used `SolrCLI#normalizeSolrUrl`is updated to behave differently for the special case where `hostContext` is `/`. Any usage of `PostTool#appendPath` is replaced to avoid custom concatenation. # Tests Since the `appendPath` method is removed, the tests for that method are also removed. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
