janhoy commented on code in PR #2785:
URL: https://github.com/apache/solr/pull/2785#discussion_r1810888872


##########
solr/packaging/test/test_status.bats:
##########
@@ -33,9 +33,36 @@ teardown() {
   assert_output --partial "No Solr nodes are running."
   run solr start
   run solr status
-  assert_output --partial "Found 1 Solr nodes:"
+  assert_output --partial "running on port ${SOLR_PORT}"
   run solr stop
   run solr status
   assert_output --partial "No Solr nodes are running."
+}
+
+@test "status with --solr-url from user" {
+  solr start
+  run solr status --solr-url http://localhost:${SOLR_PORT}
+  assert_output --partial "\"solr_home\":"
+  solr stop
+}
+
+@test "status with --port from user" {
+  solr start
+  run solr status --port ${SOLR_PORT}
+  assert_output --partial "running on port ${SOLR_PORT}"
+  solr stop
+}
+
+@test "status with invalid --solr-url from user" {
+  solr start
+  run solr status --solr-url http://invalidhost:${SOLR_PORT}
+  assert_output --partial "Solr at http://invalidhost:${SOLR_PORT} not online"
+  solr stop
+}
 
+@test "status with --short format" {

Review Comment:
   Well, `--short` is kind of feature creep here, my thought was to make it 
easier to run this cmd as part of scripts, where one URL per line can be 
parsed... But it could be removed too...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to