zkendall commented on code in PR #2799:
URL: https://github.com/apache/solr/pull/2799#discussion_r1818181714
##########
solr/core/src/test/org/apache/solr/cloud/SplitShardTest.java:
##########
@@ -89,15 +93,7 @@ public void doTest() throws IOException, SolrServerException
{
.setShardName("shard1");
splitShard.process(cluster.getSolrClient());
waitForState(
- "Timed out waiting for sub shards to be active. Number of active
shards="
- + cluster
- .getSolrClient()
- .getClusterState()
- .getCollection(COLLECTION_NAME)
- .getActiveSlices()
- .size(),
- COLLECTION_NAME,
- activeClusterShape(6, 6));
+ "Timed out waiting for 6 shards after split", COLLECTION_NAME,
activeClusterShape(6, 6));
Review Comment:
Previous code was querying for shard count as if that would be run at
failure time, which isn't the case since it's just concatenated into a string
before the waiting/predicate runs, so made more accurate and simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
