David Smiley created SOLR-17518:
-----------------------------------
Summary: Refactor out a XmlRequestWriter so that RequestWriter is
abstract
Key: SOLR-17518
URL: https://issues.apache.org/jira/browse/SOLR-17518
Project: Solr
Issue Type: Task
Security Level: Public (Default Security Level. Issues are Public)
Components: SolrJ
Reporter: David Smiley
RequestWriter writes XML; some subclasses write other things. This is terrible
API design; the XML choice should be a subclass, RequestWriter should be
abstract (or an interface).
While we're at this, the XML generation is kind of split into multiple places;
it should be consolidated: UpdateRequest & ClientUtils have XML generation
methods. Those methods should move to the new XmlRequestWriter.
BinaryRequestWriter should probably be final and/or ensure the CBOR one does
not subclass it, which is weird since CBOR != "javabin".
Be sure to note this refactoring in the update notes since SolrJ users will be
impacted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
