gerlowskija commented on code in PR #2765:
URL: https://github.com/apache/solr/pull/2765#discussion_r1819471160
##########
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##########
@@ -2097,10 +2098,19 @@ public void doReplay(TransactionLog translog) {
UpdateRequestProcessorChain processorChain =
req.getCore().getUpdateProcessingChain(null);
Collection<UpdateRequestProcessor> procPool =
Collections.synchronizedList(new ArrayList<>());
+ final var params =
+ new MapSolrParams(
+ Map.of(
+ DISTRIB_UPDATE_PARAM,
+ FROMLEADER.toString(),
+ DistributedUpdateProcessor.LOG_REPLAY,
+ "true"));
Review Comment:
> The UpdateCommand is created from the parent request but the URP is
created from the local request
Yeah, agreed. I also tried a larger refactor of the
SolrQueryRequest/UpdateCommand boundary, but ultimately landed on it being "too
much scope" to take on at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
