dsmiley commented on code in PR #2703:
URL: https://github.com/apache/solr/pull/2703#discussion_r1821330874


##########
solr/packaging/test/test_start_solr.bats:
##########
@@ -59,13 +59,24 @@ teardown() {
 @test "check stop command doesn't hang" {
   # for start/stop/restart we parse the args separate from picking the command
   # which means you don't get an error message for passing a start arg, like 
--jvm-opts to a stop commmand.
-  
+
   # Set a timeout duration (in seconds)
   TIMEOUT_DURATION=2
 
   # make sure that passing a non flag option (i.e --jvm-opts "blah") doesn't 
hang the stop command.
   run timeout $TIMEOUT_DURATION solr stop --jvm-opts
-    
+
   assert_output --partial "ERROR: JVM options are required when using the 
--jvm-opts option!"
-  
+
+}
+
+@test "SOLR-16976 solr starts with remote JMX enabled" {
+  export ENABLE_REMOTE_JMX_OPTS=true
+  export RMI_PORT=65535 # need to make sure we don't exceed port range so hard 
code it
+
+  solr start
+  solr assert --started http://localhost:${SOLR_PORT} --timeout 5000
+
+  run cat ${SOLR_LOGS_DIR}/solr-${SOLR_PORT}-console.log
+  refute_output --partial 'java.lang.ClassNotFoundException: 
org.apache.logging.log4j.jul.LogManager'

Review Comment:
   Lets generalize this to simply "Exception" -- we don't want *any* exceptions 
printed for whatever reason (JUL or otherwise).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to