dsmiley commented on PR #2824: URL: https://github.com/apache/solr/pull/2824#issuecomment-2448733108
So the change is to non-test code but it's actually about tests? Would it be more accurate to say that there was a partial/broken attempt to make a cluster-wide default for PRS but this PR completes that? nit: assuming this system property isn't really advertised/documented, I'd rather it be "solr.cloud.prs" (maybe ".enabled" suffix) and not have the word "default" in it. No sys props needs "default" as a system prop by its very nature is a kind of default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
