dsmiley commented on code in PR #2828:
URL: https://github.com/apache/solr/pull/2828#discussion_r1827982607
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##########
@@ -699,11 +699,20 @@ public NamedList<Object> request(
if (e.getRootCause() instanceof IOException) {
ex = e;
moveAliveToDead(wrapper);
- if (justFailed == null) justFailed = new HashMap<>();
+ if (justFailed == null) {
+ justFailed = new HashMap<>();
+ }
Review Comment:
It's a shame to see duplication in getRootCause IOException detection with
the dedicated clause. Maybe it'd be cleaner to have another try-catch just
around calling request() above that detects the IOException and throws it?
Just a thought; I leave it to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
