malliaridis commented on code in PR #389: URL: https://github.com/apache/solr/pull/389#discussion_r1832971729
########## solr/bin/solr: ########## @@ -1973,7 +1973,7 @@ fi LOG4J_CONFIG=() Review Comment: If the log4j options should always be loaded as default, we should consider adding them here instead, since the LOG4J_PROPS is only populated in examples where a custom log4j2.xml configuration is mandatory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
