aparnasuresh85 opened a new pull request, #2853: URL: https://github.com/apache/solr/pull/2853
# Description Address a test failure in `ClusterStateProviderTest.testGetClusterStatus` when `ClusterStateProvider` (CSP) chosen is `Http2ClusterStateProvider`. More importantly, while `ClusterStateProvider.getClusterStatus() `is highly discouraged, it should still be functional since there are codepaths using it. # Solution If a call to get CLUSTERSTATUS intending to get collections data specifies a null value for collection parameter, proceed to fetch entire cluster status since fetching the remaining (live_nodes, cluster properties, roles etc) should not be time consuming anyway. # Tests Ensure ClusterStateProviderTest.testGetClusterState() passes when chosen CSP is Http2ClusterStateProvider. (Currently the test fails with a NPE) # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
